Added support for Flask 2. Setup.py-dependency bumped to < 3.0.0. Closes #1022#1072
Added support for Flask 2. Setup.py-dependency bumped to < 3.0.0. Closes #1022#1072mortendaehli wants to merge 3 commits intocensus-instrumentation:masterfrom mortendaehli:master
Conversation
|
By the way, this is my first open source PR. Please let me know if I should do anything different, or if you have any advice. I have read the contributing guidelines and the code of conduct and tried to follow doing my best :) |
|
@aabmass, could you please review this? |
|
I was just about to make a PR for this and I'm glad I found one already open! This is desperately needed, it causes havoc on dependency resolution between popular packages that rely on flask: Maybe one for @lzchen |
|
@lzchen Could this be merged? 🙏🏼 |
|
I have updated the PR to solve a merge conflict. |
aabmass
left a comment
There was a problem hiding this comment.
Thanks for the PR and apologies for the slow response. LGTM
|
Any idea about the python 3.5 error? Is it related to flask 2 only supporting python3.7+? |
|
Could this be merged? 🙏🏼 |
|
Flask 2 does not support Python 3.5. Any chance we could drop Python 3.5? It reached end of life more than 1 year ago. |
lzchen
left a comment
There was a problem hiding this comment.
Sorry for the late review. Regarding the Python 3.5 error, we have not decided to stop supporting Py3.5 yet. Perhaps you can modify the tox file to simply ignore running on 3.5 for now?
|
Any news on this issue? We would really appreciate the merge as our security scanner forces us to disable this package until then :( Thanks a lot. |
|
+1 any preview to release new package allowing to use with flask 2? |
|
Ping. Any update on this? |
|
Ping. We would be very interested in an update here as we are not able to use the new awesome Flask version with support for multi threading. |
|
Same, desperately waiting for this PR to be merged and released |
|
This is also blocking us at the moment. |
|
Any news here? what's happening on the py35 build? |
|
@mortendaehli |
FlaskMiddleware is compatible with Flask 2. The dependency is thus bumped in setup.py to < 3.0.0.
Closes #1022